Conversation
tbenr
reviewed
Sep 4, 2026
| } | ||
| return true; | ||
| private static boolean internalErrorToBeConsiderAsInvalidBlock(final Throwable internalError) { | ||
| // hasCause also checks the exception itself |
Contributor
There was a problem hiding this comment.
what about the original internalError instanceof RejectedExecutionException || ?
Contributor
Author
There was a problem hiding this comment.
it's opposite originally
private boolean internalErrorToBeConsiderAsInvalidBlock(final Throwable internalError) {
if (internalError instanceof RejectedExecutionException
|| ExceptionUtil.hasCause(internalError, RejectedExecutionException.class)) {
return false;
}
i guess because we don't want to stuck forever on EL malfunctioning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Replacement of broad rule which could mark block invalid incorrectly
Fixed Issue(s)
Fixes #11225
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes consensus-adjacent fork-choice behavior when imports fail with internal errors; incorrect classification could still accept bad blocks or delay invalid detection, but it fixes wrongly blacklisting valid chain segments.
Overview
Tightens when
INTERNAL_ERRORblock imports are cached as invalid inBlockManager, so transient or node-local failures no longer poison the invalid-block cache.Previously, any internal error except
RejectedExecutionExceptioncauseddropInvalidBlockonINTERNAL_ERROR. The PR inverts that to an allowlist: only causes that clearly implicate block content—StateTransitionException,BlockProcessingException, SSZ/schema errors,BlsException, andArithmeticException(including wrapped causes)—mark the block invalid. Errors like queue exhaustion, OOM, capacity limits, or unknown runtime failures leave the block unmarked, avoiding wrongful rejection of canonical chain descendants until cache eviction.Tests are expanded to parameterized cases for both “do not mark invalid” and “mark invalid” exception families, with shared setup via
setupBlockFailingImportWith.Reviewed by Cursor Bugbot for commit 35bd3d8. Bugbot is set up for automated code reviews on this repo. Configure here.